W dniu 26.01.2016 o 16:23, Thomas Monjalon pisze: > 2016-01-20 10:48, krytarowski at caviumnetworks.com: >> --- a/tools/dpdk_nic_bind.py >> +++ b/tools/dpdk_nic_bind.py >> - for line in loaded_mods: >> + try: >> + # Get list of syfs modules, some of them might be builtin and merge >> with mods > Please could you explain this comment? > Is it remaining from previous versions of the patch?
Yes. It might be changed to: # Get list of sysfs modules (both built-in and dynamically loaded) > [...] >> + # special case for vfio_pci (module is named vfio-pci, >> + # but its .ko is named vfio_pci) > Isn't it common to have dash replaced by underscore for kernel modules? > I retained the logic for special case of vfio-pci. At the moment (according to my knowledge) there are no other DPDK modules with this name replacement. I checked few example Linux modules and if a module is named with dash, it's being replaced to underscore. The modprobe(8) tool can accept both names as interchangeable (with dash and underscore). Would you like to make it a general rule and replace all dashes with underscores? Thank you