> -----Original Message----- > From: Yigit, Ferruh > Sent: Wednesday, July 06, 2016 12:26 PM > To: De Lara Guarch, Pablo; dev at dpdk.org > Cc: Doherty, Declan; Jain, Deepak K > Subject: Re: [dpdk-dev] [PATCH v3 1/3] kasumi: add new KASUMI PMD > > On 6/20/2016 3:40 PM, Pablo de Lara wrote: > > Added new SW PMD which makes use of the libsso_kasumi SW library, > > which provides wireless algorithms KASUMI F8 and F9 > > in software. > > > > This PMD supports cipher-only, hash-only and chained operations > > ("cipher then hash" and "hash then cipher") of the following > > algorithms: > > - RTE_CRYPTO_SYM_CIPHER_KASUMI_F8 > > - RTE_CRYPTO_SYM_AUTH_KASUMI_F9 > > > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch at intel.com> > > Acked-by: Jain, Deepak K <deepak.k.jain at intel.com> > > ... > > > --- a/lib/librte_cryptodev/rte_cryptodev.h > > +++ b/lib/librte_cryptodev/rte_cryptodev.h > > @@ -59,12 +59,15 @@ extern "C" { > > /**< Intel QAT Symmetric Crypto PMD device name */ > > #define CRYPTODEV_NAME_SNOW3G_PMD ("cryptodev_snow3g_pmd") > > /**< SNOW 3G PMD device name */ > > +#define CRYPTODEV_NAME_KASUMI_PMD ("cryptodev_kasumi_pmd") > > +/**< KASUMI PMD device name */ > > > > /** Crypto device type */ > > enum rte_cryptodev_type { > > RTE_CRYPTODEV_NULL_PMD = 1, /**< Null crypto PMD */ > > RTE_CRYPTODEV_AESNI_GCM_PMD, /**< AES-NI GCM PMD */ > > RTE_CRYPTODEV_AESNI_MB_PMD, /**< AES-NI multi buffer PMD > */ > > + RTE_CRYPTODEV_KASUMI_PMD, /**< KASUMI PMD */ > Does adding new field into middle cause a ABI breakage? > Since now value of below fields changed.
Right! Thanks for the catch, will send a patch to fix that. > > Btw, librte_cryptodev is not listed in release notes, "shared library > versions" section, not sure if this is intentional. > > > RTE_CRYPTODEV_QAT_SYM_PMD, /**< QAT PMD Symmetric > Crypto */ > > RTE_CRYPTODEV_SNOW3G_PMD, /**< SNOW 3G PMD */ > > }; > > ...