On 07/13/2016 07:42 PM, Jan Viktorin wrote: > On Wed, 13 Jul 2016 11:27:18 +0200 > Maxime Coquelin <maxime.coquelin at redhat.com> wrote: > >> Hi Jan, >> >> On 07/13/2016 11:24 AM, Jan Viktorin wrote: >>> GCC 6 is complaining and seems to be correct here. >>> >>> virtio_user_ethdev.c:345:2: error: >>> this ?if? clause does not guard... [-Werror=misleading-indentation] >>> if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_PATH) == 1) >>> ^~ >>> >>> virtio_user_ethdev.c:348:3: note: >>> ...this statement, but the latter is misleadingly indented >>> as if it is guarded by the ?if? >>> if (ret < 0) { >>> >>> Fixes: 404bd6bfe360 ("net/virtio-user: fix return value not checked") >>> Signed-off-by: Jan Viktorin <viktorin at rehivetech.com> >>> --- >>> >> I already fixed it yesterday: >> http://dpdk.org/dev/patchwork/patch/14780/ > > Sorry, I didn't find it quickly. My fault. Thanks. Oh no problem! Better having two fixes than none :)
Thanks, Maxime