Thanks Keith for continuing work. 2016-07-14 14:31, Keith Wiles: > Moving the rte_rtm_init() constructor routine out of the > header file and into a new rte_spinlock.c for all archs/platforms. > Having constructor routines in a header file is not a good > place to keep these types of functions. > > The problem is with linking 3rd party libraries when > an application is not linked directly to dpdk libraries, which > in this case causes a missing symbol in the linking phase. > > Fixes: ba7468997ea6 ("spinlock: add HTM lock elision for x86") > > Originally submitted by Damjan Marion <damarion at cisco.com>
You should keep the original Signed-off and authorship (From: field) with "git am". It is also easier to track when using -v2 --in-reply-to='<v1-id>'. > Signed-off-by: Keith Wiles <keith.wiles at intel.com> > --- > lib/librte_eal/bsdapp/eal/Makefile | 1 + > lib/librte_eal/common/arch/arm/rte_spinlock.c | 46 > ++++++++++++++++++++++ > lib/librte_eal/common/arch/ppc_64/rte_spinlock.c | 46 > ++++++++++++++++++++++ > lib/librte_eal/common/arch/tile/rte_spinlock.c | 46 > ++++++++++++++++++++++ > lib/librte_eal/common/arch/x86/rte_spinlock.c | 46 > ++++++++++++++++++++++ > .../common/include/arch/x86/rte_spinlock.h | 14 ++----- > lib/librte_eal/linuxapp/eal/Makefile | 1 + I am not sure we should add a .c file for each arch, given it is called only from arch/x86/rte_spinlock.h.