On Mon, Jun 13, 2016 at 12:08 PM, Thomas Monjalon <thomas.monjalon at 6wind.com > wrote:
> 2016-06-13 11:48, Christian Ehrhardt: > > --- a/drivers/net/af_packet/Makefile > > +++ b/drivers/net/af_packet/Makefile > > @@ -54,5 +54,6 @@ SRCS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += > rte_eth_af_packet.c > > DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += lib/librte_mbuf > > DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += lib/librte_ether > > DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += lib/librte_kvargs > > +DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += lib/librte_eal > > It looks more logical to have eal as first DEPDIR in these lists. Yeah, thought about alphanumeric order, but eal first should be most appropriate. > > --- a/drivers/net/vhost/Makefile > > +++ b/drivers/net/vhost/Makefile > > @@ -36,6 +36,8 @@ include $(RTE_SDK)/mk/rte.vars.mk > > # > > LIB = librte_pmd_vhost.a > > > > +LDLIBS += -lpthread > > + > > It is not a DEPDIR but an external dependency. It deserves a separate patch. > Yes, sorry for just wrapping it in. Will send a v2 with both changes later. > Do we need it in rte.app.mk? It is an EAL dependency as well. > Not IMHO: EAL depends on it so librte_eal.so depends on it as it should (just reverified by ldd). I don't see a reason that any app created should depend on pthread other than if it actually uses libpthread.