> -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, June 17, 2016 9:19 AM > To: Jain, Deepak K <deepak.k.jain at intel.com> > Cc: dev at dpdk.org; Griffin, John <john.griffin at intel.com>; De Lara > Guarch, > Pablo <pablo.de.lara.guarch at intel.com>; Doherty, Declan > <declan.doherty at intel.com> > Subject: Re: [dpdk-dev] [PATCH] qat: fix for VFs not getting recognized > > 2016-06-16 16:25, Jain, Deepak K: > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > > 2016-06-16 16:29, Jain, Deepak K: > > > > Due to addition of CLASS_ID in EAL, class_id is amended into the code. > > > > > > Why the VF is not recognized? > > > The class id should not be mandatory. > > > > Without the change proposed, QuickAssist Devices were not visible and > hence tests were not running. > > Seems like changes in EAL especially where class_id is added affected the > QuickAssist tests. > > With this change, QuickAssist devices are visible during tests and tests > working fine. > > Which tests? > Have you investigated why?
Hi Thomas, On investigation, I found that when class_id is not set in the rte_qat_cryptodev.c, the value of id_table->class_id defaults to 0. Hence the following code snippet always executes and the probing of driver is never done. if (id_table->class_id != dev->id.class_id && id_table->class_id != RTE_CLASS_ANY_ID continue; If value of id_table->class_id is set, as shown in patch which was submitted, the id_table->class_ID is set to RTE_CLASS_ANY_ID and hence its probes the driver and fixes the issues. Other fix would be to set default value of class_id equal to RTE_CLASS_ANY_ID instead of 0.