On Fri, Jun 17, 2016 at 5:25 PM, Thomas Monjalon
<thomas.monjalon at 6wind.com> wrote:
> rte_thread_setname was a macro defined only for Linux.
> The function rte_thread_setname() can now be used on FreeBSD
> as well on Linux.
> It is required to build librte_pdump.
>
> The macro was 0 for old glibc. The function is now returning -1.
> The related logs are decreased from error to debug level because
> it is not an important failure, just a debug inconvenience.
>
> Fixes: 278f945402c5 ("pdump: add new library for packet capture")
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon at 6wind.com>[snip] > diff --git a/lib/librte_eal/common/include/rte_lcore.h > b/lib/librte_eal/common/include/rte_lcore.h > index ac15130..1dcfba7 100644 > --- a/lib/librte_eal/common/include/rte_lcore.h > +++ b/lib/librte_eal/common/include/rte_lcore.h > @@ -250,23 +250,16 @@ void rte_thread_get_affinity(rte_cpuset_t *cpusetp); > /** > * Set thread names. > * > - * Macro to wrap `pthread_setname_np()` with a glibc version check. > - * Only glibc >= 2.12 supports this feature. > + * @note Only glibc >= 2.12 supports this feature. This comment is a bit weird since, this only applies to Linux and not BSD, right ? The rest looks good to me. -- David Marchand
