2016-06-16 20:49, Jain, Deepak K:
> From: Declan Doherty <declan.doherty at intel.com>
> 
> Adding rte_crypto_op_bulk_free to free up the ops in bulk
> so as to expect improvement in performance.
> 
> Signed-off-by: Declan Doherty <declan.doherty at intel.com>

I wonder why these changes are dropped so late?

>  /**
> + * free crypto operation structure
> + * If operation has been allocate from a rte_mempool, then the operation will
> + * be returned to the mempool.
> + *
> + * @param    op      symmetric crypto operation
> + */

Please check punctuation, grammar and document every parameters.

> +static inline void
> +rte_crypto_op_bulk_free(struct rte_mempool *mpool, struct rte_crypto_op 
> **ops,
> +             uint16_t nb_ops)

Reply via email to