On 3/1/2016 2:29 PM, Panu Matilainen wrote: > On 02/29/2016 06:41 PM, Tan, Jianfeng wrote: >> Hi Panu, >> >> On 2/29/2016 7:34 PM, Panu Matilainen wrote: > [...] >>> >>> More importantly, to export a function you need to add an entry for it >>> in rte_ether_version.map. >> >> Oh, yes, thanks for pointing out this, I'll change this and update >> rte_ether_version.map. >> >> Is it like this? Before or after DPDK_2.2 {}? >> DPDK_2.3 { >> global: >> >> rte_eth_dev_get_ptype_info; >> >> local: *; >> }; > > Sorry I didn't have a chance to reply to this yesterday and I see you > already posted a v6 with the above, which is almost but not quite > there: it needs to inherit from DPDK_2.2, ie > > DPDK_2.3 { > global: > > rte_eth_dev_get_ptype_info; > > local: *; > } DPDK_2.2; > > ...but if there are no other reasons to respin the series perhaps > Thomas can fixup that while applying.
OK, thanks. Should I add this new API into _API Changes_ section in doc/guides/rel_notes/release_16_04.rst? > > Then there's the actual version, which should optimally be DPDK_16.04 > but that's purely cosmetical. There are a number of patches floating > around with DPDK_2.3 {} and librte_eal actually has one on board, so > clearly the dust from versioning change has not yet settled. Maybe Thomas can give some advice here? DPDK_2.3 or DPDK_16.04 be used here? Thanks, Jianfeng > > - Panu - > >> >> Thanks, >> Jianfeng >> >>> >>> - Panu - >>> >>> >> >