> > CRC32c computation is not valid when buffer length is not a multiple of 4 > > bytes. > > Values returned by rte_hash_crc functions does not match the one > > computed by a trivial crc32c implementation. > > > > First patch fixes crc hash function autotests, to outline the problem. > > Second patch fixes CRC32c computation. > > > > Didier Pallard (2): > > test: fix CRC hash function autotest > > hash: fix CRC32c computation > > Series-acked-by: Pablo de Lara <pablo.de.lara.guarch at intel.com> > > Not sure if you need to include a "Fixes" line in the commit messages. > In the first commit, probably you should, the commit that you are fixing is > 6298d2c55ae8 ("app/test: add new functional tests for hash functions").
Thanks > In the second commit, it is a bit more difficult, as we don't know that the > commit is, > that code was integrated a while ago, before 1.2.3, which is the first public > release in dpdk.org. Yes it helps to know the bug was there since the beginning. > Also, there is a typo "lengthes", in both commit messages. > > You can leave the ack in both patches. Thanks!! Applied, thanks