On Tue, 1 Mar 2016 13:36:39 +0800 Wang Xiao W <xiao.w.wang at intel.com> wrote:
> > +static int > +fm10k_check_ftag(struct rte_devargs *devargs) > +{ > + if (devargs == NULL) > + return 0; > + > + if (strstr(devargs->args, "enable_ftag=1") == NULL) > + return 0; > + > + return 1; > +} > + It is good to see the DPDK keeping up with the leading edge of hardware support. My issue is that devargs are the Linux module parameters method of configuration in the DPDK world. They are an API only a developer would love.. 1. It has to be done at boot 2. Applications have to rewrite (or expect customer) to pass args 3. Can't be changed at runtime 4. Can't be selected on per device basis. Please find a better way.