On 03/03/2016 12:36 PM, Thomas Monjalon wrote: > 2016-03-02 22:04, Bruce Richardson: >> On Wed, Mar 02, 2016 at 03:22:23PM +0100, Thomas Monjalon wrote: >>> From: Panu Matilainen <pmatilai at redhat.com> >>> >>> Add RTE_DEVEL_BUILD make-variable which can be used to do things >>> differently when doing development vs building a release, >>> autodetected from source root .git presence and overridable via >>> commandline. It is used it to enable -Werror compiler flag and may >>> be extended to other checks. >>> >>> Failing build on warnings is a useful developer tool but its bad >>> for release tarballs which can and do get built with newer >>> compilers than what was used/available during development. Compilers >>> routinely add new warnings so code which built silently with cc X >>> might no longer do so with X+1. This doesn't make the existing code >>> any more buggier and failing the build in this case does not help >>> to improve the quality of an already released version either. >>> >>> This change the default flags which can be tuned with EXTRA_CFLAGS. >>> >>> Signed-off-by: Panu Matilainen <pmatilai at redhat.com> >>> Signed-off-by: Thomas Monjalon <thomas.monjalon at 6wind.com> >> >> Acked-by: Bruce Richardson <bruce.richardson at intel.com> > > Applied, thanks
Thanks for dusting this up, I'd pretty much forgotten the whole thing. - Panu -