> -----Original Message----- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ferruh Yigit > Sent: Thursday, March 03, 2016 5:08 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] igb_uio: use macros for array size calculation > > Minor code cleanup. > Remove array size calculations and remove unnecessary assignment. > > Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com> > --- > lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > index 3374e44..563c57b 100644 > --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > @@ -58,7 +58,7 @@ struct rte_uio_pci_dev { > enum rte_intr_mode mode; > }; > > -static char *intr_mode = NULL; > +static char *intr_mode; > static enum rte_intr_mode igbuio_intr_mode_preferred = RTE_INTR_MODE_MSIX; > > /* sriov sysfs */ > @@ -332,7 +332,7 @@ igbuio_pci_setup_iomem(struct pci_dev *dev, struct > uio_info *info, > unsigned long addr, len; > void *internal_addr; > > - if (sizeof(info->mem) / sizeof(info->mem[0]) <= n) > + if (n >= MAX_UIO_MAPS)
Why using hardcoded value is better than sizeof()? As I can see below there is a macro ARRAY_SIZE, why not to use it here then? Konstantin > return -EINVAL; > > addr = pci_resource_start(dev, pci_bar); > @@ -357,7 +357,7 @@ igbuio_pci_setup_ioport(struct pci_dev *dev, struct > uio_info *info, > { > unsigned long addr, len; > > - if (sizeof(info->port) / sizeof(info->port[0]) <= n) > + if (n >= MAX_UIO_PORT_REGIONS) > return -EINVAL; > > addr = pci_resource_start(dev, pci_bar); > @@ -402,7 +402,7 @@ igbuio_setup_bars(struct pci_dev *dev, struct uio_info > *info) > iom = 0; > iop = 0; > > - for (i = 0; i != sizeof(bar_names) / sizeof(bar_names[0]); i++) { > + for (i = 0; i < ARRAY_SIZE(bar_names); i++) { > if (pci_resource_len(dev, i) != 0 && > pci_resource_start(dev, i) != 0) { > flags = pci_resource_flags(dev, i); > -- > 2.5.0