> -----Original Message----- > From: Aaron Conole [mailto:aconole at redhat.com] > Sent: Friday, February 26, 2016 2:49 AM > To: dev at dpdk.org > Cc: Lu, Wenzhuo <wenzhuo.lu at intel.com>; Zhang, Helin > <helin.zhang at intel.com>; Ananyev, Konstantin > <konstantin.ananyev at intel.com>; Richardson, Bruce > <bruce.richardson at intel.com> > Subject: [PATCH 4/8] drivers/net/e1000: Fix missing lsc interrupt check > brackets > > The device lsc interupt check has a misleading whitespace around it which can > be > improved by adding appropriate braces to the check. Since the ret variable was > checked after previous assignment, this introduces no functional change.
It seems a "Fixes: " line is required. > > Signed-off-by: Aaron Conole <aconole at redhat.com> > --- > drivers/net/e1000/em_ethdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c > index 4a843fe..1d86091 100644 > --- a/drivers/net/e1000/em_ethdev.c > +++ b/drivers/net/e1000/em_ethdev.c > @@ -637,13 +637,14 @@ eth_em_start(struct rte_eth_dev *dev) > > if (rte_intr_allow_others(intr_handle)) { > /* check if lsc interrupt is enabled */ > - if (dev->data->dev_conf.intr_conf.lsc != 0) > + if (dev->data->dev_conf.intr_conf.lsc != 0) { > ret = eth_em_interrupt_setup(dev); > if (ret) { > PMD_INIT_LOG(ERR, "Unable to setup interrupts"); > em_dev_clear_queues(dev); > return ret; > } > + } > } else { > rte_intr_callback_unregister(intr_handle, > eth_em_interrupt_handler, > -- > 2.5.0