> >On Tue, 29 Mar 2016 22:28:20 -0700 >Rasesh Mody <rasesh.mody at qlogic.com> wrote: > >> +static void >> +qede_mac_addr_remove(__rte_unused struct rte_eth_dev *eth_dev, >> + __rte_unused uint32_t index) >> +{ >> + struct qede_dev *qdev = eth_dev->data->dev_private; >> + struct ecore_dev *edev = &qdev->edev; >> + >> + /* TBD: Not implemented currently because DPDK does not provide >> + * macaddr and instead just passes the index. So pmd needs to >> + * maintain index mapping to macaddr. >> + */ >> + DP_NOTICE(edev, false, "%s: Unsupported operation\n", __func__); >> +} >> + > >Rather than have a stub and break software, why not just >not define the operation and let base DPDK handle the error? > Okay. I shall have it implemented and not leave it as stubbed one.
- [dpdk-dev] [PATCH v4 02/10] qede: Add documentation Rasesh Mody
- [dpdk-dev] [PATCH v4 03/10] qede: Add license file Rasesh Mody
- [dpdk-dev] [PATCH v4 04/10] qede: Add base driver Rasesh Mody
- [dpdk-dev] [PATCH v4 05/10] qede: Add core driver Rasesh Mody
- [dpdk-dev] [PATCH v4 05/10] qede: Add core driver Stephen Hemminger
- [dpdk-dev] [PATCH v4 05/10] qede: Add core driv... Harish Patil
- [dpdk-dev] [PATCH v4 05/10] qede: Add core ... Stephen Hemminger
- [dpdk-dev] [PATCH v4 05/10] qede: Add c... Harish Patil
- [dpdk-dev] [PATCH v4 05/10] qede: ... Stephen Hemminger
- [dpdk-dev] [PATCH v4 05/10] qede: Add core driver Stephen Hemminger
- [dpdk-dev] [PATCH v4 05/10] qede: Add core driv... Harish Patil
- [dpdk-dev] [PATCH v4 05/10] qede: Add core driver Stephen Hemminger
- [dpdk-dev] [PATCH v4 05/10] qede: Add core driver Stephen Hemminger
- [dpdk-dev] [PATCH v4 05/10] qede: Add core driver Stephen Hemminger
- [dpdk-dev] [PATCH v4 05/10] qede: Add core driv... Harish Patil
- [dpdk-dev] [PATCH v4 05/10] qede: Add core driver Stephen Hemminger
- [dpdk-dev] [PATCH v4 05/10] qede: Add core driver Stephen Hemminger
- [dpdk-dev] [PATCH v4 06/10] qede: Add L2 support Rasesh Mody
- [dpdk-dev] [PATCH v4 07/10] qede: Add SRIOV support Rasesh Mody
- [dpdk-dev] [PATCH v4 08/10] qede: Add attention support Rasesh Mody
- [dpdk-dev] [PATCH v4 09/10] qede: Add DCBX support Rasesh Mody