Hi Yuanhan, > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Thursday, May 5, 2016 11:28 AM > To: Tan, Jianfeng > Cc: dev at dpdk.org; Xie, Huawei > Subject: Re: [dpdk-dev] [PATCH v3 2/2] virtio: fix memory leak of virtqueue > memzones > > ping... > > On Thu, Apr 28, 2016 at 10:33:08PM -0700, Yuanhan Liu wrote: > > On Fri, Apr 29, 2016 at 12:48:46AM +0000, Jianfeng Tan wrote: > > > @@ -447,6 +453,7 @@ int virtio_dev_queue_setup(struct rte_eth_dev > *dev, > > > > > > hw->vtpci_ops->setup_queue(hw, vq); > > > > > > + vq->started = 1; > > > > Judging that this is in the "_queue_setup" stage, and we have another > > stage called "_dev_start", naming it to "started" seems confusing then. > > > > So, how about naming it to something like "configured"? Besides that, > > this patch set looks good to me. If you agree the name change, or have > > better idea, I could fix it while applying it.
Yes, I agree _configured_ would be better. Thanks, Jianfeng > > > > --yliu
