> -----Original Message----- > From: Olivier Matz [mailto:olivier.matz at 6wind.com] > Sent: Monday, May 23, 2016 10:13 AM > To: Ananyev, Konstantin; dev at dpdk.org > Cc: johndale at cisco.com; Zhang, Helin; adrien.mazarguil at 6wind.com; > rahul.lakkireddy at chelsio.com; > alejandro.lucero at netronome.com; sony.chacko at qlogic.com > Subject: Re: [PATCH] mbuf: new flag when Vlan is stripped > > Hi Konstantin, > > On 05/23/2016 10:59 AM, Ananyev, Konstantin wrote: > > Hi Olivier, > > > >> -----Original Message----- > >> From: Olivier Matz [mailto:olivier.matz at 6wind.com] > >> Sent: Monday, May 23, 2016 9:47 AM > >> To: dev at dpdk.org > >> Cc: johndale at cisco.com; Ananyev, Konstantin; Zhang, Helin; > >> adrien.mazarguil at 6wind.com; rahul.lakkireddy at chelsio.com; > >> alejandro.lucero at netronome.com; sony.chacko at qlogic.com > >> Subject: [PATCH] mbuf: new flag when Vlan is stripped > >> > >> The behavior of PKT_RX_VLAN_PKT was not very well defined, resulting in > >> PMDs not advertising the same flags in similar conditions. > >> > >> Following discussion in [1], introduce 2 new flags PKT_RX_VLAN_STRIPPED > >> and PKT_RX_QINQ_STRIPPED that are better defined: > >> > >> PKT_RX_VLAN_STRIPPED: a vlan has been stripped by the hardware and its > >> tci is saved in mbuf->vlan_tci. This can only happen if vlan stripping > >> is enabled in the RX configuration of the PMD. > >> > >> For now, the old flag PKT_RX_VLAN_PKT is kept but marked as deprecated. > >> It should be removed from applications and PMDs in a future revision. > >> > >> This patch also updates the drivers. For PKT_RX_VLAN_PKT: > >> > >> - e1000, enic, i40e, mlx5, nfp, vmxnet3: done, PKT_RX_VLAN_PKT already > >> had the same meaning than PKT_RX_VLAN_STRIPPED, minor update is > >> required. > >> - fm10k: done, PKT_RX_VLAN_PKT already had the same meaning than > >> PKT_RX_VLAN_STRIPPED, and vlan stripping is always enabled on fm10k. > >> - ixgbe: modification done for standard mode (vector does not support > >> vlan stripping) > >> - the other drivers do not support vlan stripping. > >> > >> For PKT_RX_QINQ_PKT, it was only supported on i40e, and the meaning was > >> already correct, so we can reuse the same value for PKT_RX_QINQ_STRIPPED. > >> > > > > I don't see ixgbe/i4oe_rxtx_vec.c updated. > > Would it be another patch for them? > > The ixgbe vector and i40e vector do not support vlan stripping,
As I remember, they do. Konstantin >so from what I see there is nothing to do: > - The new flag PKT_RX_VLAN_STRIPPED is never returned > - We keep the old behavior for PKT_RX_VLAN_PKT. > > Thanks, > Olivier