Hi Ben, On Thursday 24 November 2016 01:37 AM, Ben Walker wrote: > rte_eal_pci_scan can be called repeatedly to re-scan the PCI > bus. If a device was removed from the system, the associated > driver will automatically be unloaded. > > Signed-off-by: Ben Walker <benjamin.walker at intel.com> > --- [...]
While reviewing, I found that there are some checkpatch warnings on this patch: --->8--- ### [PATCH v2 4/7] pci: rte_eal_pci_scan now handles removal of PCI devices WARNING:LONG_LINE_COMMENT: line over 80 characters #76: FILE: lib/librte_eal/linuxapp/eal/eal_pci.c:490: + /* Search the device list for devices that are no longer present on the system WARNING:LONG_LINE_STRING: line over 80 characters #105: FILE: lib/librte_eal/linuxapp/eal/eal_pci.c:519: + RTE_LOG(DEBUG, EAL, "PCI device "PCI_PRI_FMT" was removed.\n", WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #111: FILE: lib/librte_eal/linuxapp/eal/eal_pci.c:525: + * Unload it. */ WARNING:LONG_LINE_STRING: line over 80 characters #112: FILE: lib/librte_eal/linuxapp/eal/eal_pci.c:526: + RTE_LOG(DEBUG, EAL, " Unload driver: %x:%x %s\n", WARNING:LONG_LINE: line over 80 characters #113: FILE: lib/librte_eal/linuxapp/eal/eal_pci.c:527: + dev->id.vendor_id, dev->id.device_id, WARNING:LONG_LINE_COMMENT: line over 80 characters #117: FILE: lib/librte_eal/linuxapp/eal/eal_pci.c:531: + /* It doesn't matter what remove returns - WARNING:LONG_LINE_COMMENT: line over 80 characters #118: FILE: lib/librte_eal/linuxapp/eal/eal_pci.c:532: + * we're removing the device either way. */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #118: FILE: lib/librte_eal/linuxapp/eal/eal_pci.c:532: + * we're removing the device either way. */ WARNING:LONG_LINE: line over 80 characters #125: FILE: lib/librte_eal/linuxapp/eal/eal_pci.c:539: + if (dev->driver->drv_flags & RTE_PCI_DRV_NEED_MAPPING) total: 0 errors, 9 warnings, 69 lines checked --->8---
