On 11/25/2016 01:17 PM, Ferruh Yigit wrote: > On 11/24/2016 3:59 PM, Andrew Rybchenko wrote: >> On 11/23/2016 06:26 PM, Ferruh Yigit wrote: >>> On 11/21/2016 3:00 PM, Andrew Rybchenko wrote: >>>> The PMD is put into the sfc/efx subdirectory to have a place for >>>> the second PMD and library shared by both. >>>> >>>> Enable the PMD by default on supported configuratons. >>>> >>>> Reviewed-by: Andy Moreton <amoreton at solarflare.com> >>>> Signed-off-by: Andrew Rybchenko <arybchenko at solarflare.com> >>>> --- >>>> MAINTAINERS | 6 ++ >>>> config/common_base | 6 ++ >>>> config/defconfig_arm-armv7a-linuxapp-gcc | 1 + >>>> config/defconfig_arm64-armv8a-linuxapp-gcc | 1 + >>>> config/defconfig_i686-native-linuxapp-gcc | 5 + >>>> config/defconfig_i686-native-linuxapp-icc | 5 + >>>> config/defconfig_ppc_64-power8-linuxapp-gcc | 1 + >>>> config/defconfig_tile-tilegx-linuxapp-gcc | 1 + >>>> config/defconfig_x86_64-native-linuxapp-icc | 5 + >>>> config/defconfig_x86_x32-native-linuxapp-gcc | 5 + >>>> doc/guides/nics/features/sfc_efx.ini | 10 ++ >>>> doc/guides/nics/index.rst | 1 + >>>> doc/guides/nics/sfc_efx.rst | 109 >>>> +++++++++++++++++++++
<...> >>> And you can add extra options here, please keep in mind that there are >>> three compiler supported right now: gcc, clang and icc. You may require >>> to add compiler and version checks.. >> I've tried to disable the driver build on ICC since we've never tested it. > I believe we don't support selective config per compiler. Currently if a > code is enabled by default, it should support compilation with all three > compilers. I thought that the following lines in config/defconfig_x86_64-native-linuxapp-icc do the job: # # Solarflare PMD build is not supported using icc toolchain # CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n >> I've failed to find list of compiler versions which must/should be checked. > That list is not clear as far as I know. Mostly version related fixes > added based on reported build errors. So you can leave as it is right > now, or can test with default compiler versions of some common > distributions. I see. Thanks. <...>
