On Monday 03 October 2016 07:51 PM, Thomas Monjalon wrote: > 2016-09-20 18:11, Shreyansh Jain: >> --- a/lib/librte_ether/rte_ethdev.h >> +++ b/lib/librte_ether/rte_ethdev.h >> @@ -4372,6 +4372,19 @@ rte_eth_dev_get_port_by_name(const char *name, >> uint8_t *port_id); >> int >> rte_eth_dev_get_name_by_port(uint8_t port_id, char *name); >> >> +/** >> + * Wrapper for use by pci drivers as a .probe function to attach to a ethdev >> + * interface. >> + */ >> +int rte_eth_dev_pci_probe(struct rte_pci_driver *pci_drv, >> + struct rte_pci_device *pci_dev); >> + >> +/** >> + * Wrapper for use by pci drivers as a .remove function to detach a ethdev >> + * interface. >> + */ >> +int rte_eth_dev_pci_remove(struct rte_pci_device *pci_dev); > > These functions are used by the drivers only (as helpers). > So they should be marked @internal (added after applying the patch). >
Ok. Thanks! - Shreyansh