[dpdk-dev] [PATCH v2 09/12] virtio: add Rx checksum offload support

[Olivier Matz]

On 10/05/2016 03:27 PM, Maxime Coquelin wrote:
>> @@ -903,7 +905,8 @@ virtio_recv_pkts(void *rx_queue, struct rte_mbuf
>> **rx_pkts, uint16_t nb_pkts)
>>                         rte_vlan_strip(rxm);
>>
>>                 /* Update offload features */
>> -               if (virtio_rx_offload(rxm, hdr) < 0) {
>> +               if ((features & VIRTIO_NET_F_GUEST_CSUM) &&
> s/VIRTIO_NET_F_GUEST_CSUM/(1u << VIRTIO_NET_F_GUEST_CSUM)/

oooh good catch :)

> And don't forget to update the test for LRO patch.

yep

> Except this, it sounds good.

Thanks, I'll send a v3 soon.

Olivier