From: Reshma Pattan <reshma.pat...@intel.com> Inside the function pdump_get_socket_path(), pdump socket directories are created using mkdir() call with permissions 700, which was assigning wrong permissions to the directories i.e. "d-w-r-xr-T" instead of drwx---. The reason is mkdir() call doesn't consider 700 as an octal value until unless 0 is explicitly added before the value. Because of this, socket creation failure is observed when DPDK application was ran in non root user mode. DPDK application running in root user mode never reported the issue.
So 0 is prefixed to the value to create directories with the correct permissions. Fixes: e4ffa2d3 ("pdump: fix error handlings") Fixes: bdd8dcc6 ("pdump: fix default socket path") Reported-by: Jianfeng Tan <jianfeng.tan at intel.com> Signed-off-by: Reshma Pattan <reshma.pattan at intel.com> --- lib/librte_pdump/rte_pdump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c index 9b921ce..ea5ccd9 100644 --- a/lib/librte_pdump/rte_pdump.c +++ b/lib/librte_pdump/rte_pdump.c @@ -471,12 +471,12 @@ pdump_get_socket_path(char *buffer, int bufsz, enum rte_pdump_socktype type) snprintf(dpdk_dir, sizeof(dpdk_dir), "%s%s", SOCKET_PATH_VAR_RUN, DPDK_DIR); - mkdir(dpdk_dir, 700); + mkdir(dpdk_dir, 0700); snprintf(dir, sizeof(dir), "%s%s", dpdk_dir, SOCKET_DIR); } - ret = mkdir(dir, 700); + ret = mkdir(dir, 0700); /* if user passed socket path is invalid, return immediately */ if (ret < 0 && errno != EEXIST) { RTE_LOG(ERR, PDUMP, -- 2.7.4