On Thu, Oct 13, 2016 at 04:16:11PM +0200, Olivier Matz wrote: > +/* When doing TSO, the IP length is not included in the pseudo header > + * checksum of the packet given to the PMD, but for virtio it is > + * expected. > + */ > +static void > +virtio_tso_fix_cksum(struct rte_mbuf *m) > +{ > + /* common case: header is not fragmented */ > + if (likely(rte_pktmbuf_data_len(m) >= m->l2_len + m->l3_len + > + m->l4_len)) { > + struct ipv4_hdr *iph; > + struct ipv6_hdr *ip6h; > + struct tcp_hdr *th; > + uint16_t prev_cksum, new_cksum, ip_len, ip_paylen; > + uint32_t tmp; ... > + } else {
As discussed just now, if you drop the else part, you could add my ACK for the whole virtio changes, and Review-ed by for all mbuf and other changes. Thoams, please pick them by youself directly: since it depends on other patches and they will be picked (or already be picked?) by you. Thanks. --yliu