On Wed, 19 Oct 2016, Lu, Wenzhuo wrote:
> Hi Scott, > >> -----Original Message----- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of E. Scott Daniels >> Sent: Thursday, October 20, 2016 6:23 AM >> To: Zhang, Helin; Iremonger, Bernard >> Cc: dev at dpdk.org; az5157 at att.com; E. Scott Daniels >> Subject: [dpdk-dev] [PATCH] net/ixgbe: prevent duplicate callback on list >> >> This change prevents the attempt to add a structure which is already on the >> callback list. If a struct with matching parameters is found on the list, >> then no >> action is taken. If a struct with matching parameters is found on the list, >> then no >> action is taken. >> >> Signed-off-by: E. Scott Daniels <daniels at research.att.com> > I think the fix itself is good. But 2 things, > 1, normally we don't create a cover letter for a patch set which only has one > patch. Just sending the patch itself is enough. > 2, ' net/ixgbe: ' in the title is used to describe the component. So the > title should be ' lib/ether: prevent duplicate callback on list'. > Thanks. Thanks for the advice. My mistake on the component. Is there an easy way to fix, or does it make sense just to nack this and I'll submit one with the correct component. Scott > >
