Ok will change it. Do I need to submit a new v4 for that ? can I put your name also in the reviewed by list?
-----Original Message----- From: Yuanhan Liu [mailto:yuanhan....@linux.intel.com] Sent: Tuesday, September 6, 2016 11:43 PM To: Dey, Souvik <sodey at sonusnet.com> Cc: dev at dpdk.org; stephen at networkplumber.org Subject: Re: [dpdk-dev] [PATCH v3]virtio:add mtu set in virtio On Tue, Sep 06, 2016 at 11:21:56PM -0400, souvikdey33 wrote: > +static int > +virtio_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) { > + struct virtio_hw *hw = dev->data->dev_private; > + if (mtu < VIRTIO_MIN_RX_BUFSIZE || mtu > VIRTIO_MAX_RX_PKTLEN) { > + PMD_INIT_LOG(ERR, "Mtu should be between 64 and 9728\n"); I forgot to mention in last email, that you should not use the number (64 and 9728) directly, use the MACRO instead. --yliu
