2016-09-08 18:15, Ferruh Yigit: > On 9/8/2016 5:44 PM, Stephen Hemminger wrote: > > ... > > > But then again the whole KNI driver fails completely when > > running kernel style check. > > > > Yes, it generates lots of warnings. > I can fix them (excluding ethtool/*), that wouldn't take much time but > how syntax only patches welcomed? Another concern is it trashes git blame.
You ask a question and give the answer ;) I think it depends just on the balance of the pros/cons - to be evaluated.