Hi Yuanhan, > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Sunday, September 11, 2016 8:09 PM > To: Tan, Jianfeng > Cc: dev at dpdk.org; Ananyev, Konstantin; Wu, Jingjing; Kavanagh, Mark B; > Thomas Monjalon > Subject: Re: [dpdk-dev] [PATCH 1/2] examples/tep_term: fix offload on > VXLAN failure > > On Thu, Aug 04, 2016 at 07:58:48AM +0000, Jianfeng Tan wrote: > > Based on previous fix of offload on VXLAN using i40e, applications > > need to set proper tunneling type on ol_flags so that i40e driver > > can pass it to NIC. > > > > Fixes: a50245ede72a ("examples/tep_term: initialize VXLAN sample") > > > > Signed-off-by: Jianfeng Tan <jianfeng.tan at intel.com> > > --- > > examples/tep_termination/vxlan.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/examples/tep_termination/vxlan.c > b/examples/tep_termination/vxlan.c > > index 5ee1f95..4bad33d 100644 > > --- a/examples/tep_termination/vxlan.c > > +++ b/examples/tep_termination/vxlan.c > > @@ -237,6 +237,8 @@ encapsulation(struct rte_mbuf *m, uint8_t > queue_id) > > m->outer_l2_len = sizeof(struct ether_hdr); > > m->outer_l3_len = sizeof(struct ipv4_hdr); > > > > + ol_flags |= PKT_TX_TUNNEL_VXLAN; > > + > > Hi, > > FYI, my testrobot caught some errors when this patch is applied.
It's because this patch set has dependency on a previous patch set, which seems a difficult scenario to handle. There's no standard to state the dependency, right? Thanks, Jianfeng > > --yliu > > --- > x86_64-native-linuxapp-clang: config-all-yes > ============================================ > /root/dpdk/examples/tep_termination/vxlan.c:240:14: error: use of > undeclared identifier 'PKT_TX_TUNNEL_VXLAN' > ol_flags |= PKT_TX_TUNNEL_VXLAN; > ^ > 1 error generated. > make[1]: *** [vxlan.o] Error 1 > make: *** [all] Error 2 > error: build examples/tep_termination failed > error: build failed > > ...