> 
> [...]
> 
> > >
> > > ********************************************************************
> > > ** / @@ -2290,6 +2369,7 @@ ixgbe_set_tx_function(struct rte_eth_dev
> > > *dev, struct ixgbe_tx_queue *txq)
> > >           } else
> > >  #endif
> > >           dev->tx_pkt_burst = ixgbe_xmit_pkts_simple;
> > > +         dev->tx_pkt_prep = ixgbe_prep_pkts_simple;
> >
> > Shouldn't we setup ixgbe_prep_pkts_simple when vTX is selected too?
> >
> 
> 
> It is, but source code is formatted like below:
> 
> #ifdef RTE_IXGBE_INC_VECTOR
>               if (txq->tx_rs_thresh <= RTE_IXGBE_TX_MAX_FREE_BUF_SZ &&
>                               (rte_eal_process_type() != RTE_PROC_PRIMARY ||
>                                       ixgbe_txq_vec_setup(txq) == 0)) {
>                       PMD_INIT_LOG(DEBUG, "Vector tx enabled.");
>                       dev->tx_pkt_burst = ixgbe_xmit_pkts_vec;

Yep, so I thought we need a:
dev->tx_pkt_prep = ixgbe_prep_pkts_simple;
here too, no?

Konstantin


>               } else
> #endif
>               dev->tx_pkt_burst = ixgbe_xmit_pkts_simple;
>               dev->tx_pkt_prep = ixgbe_prep_pkts_simple;
> 
> 
> > >   } else {
> > >           PMD_INIT_LOG(DEBUG, "Using full-featured tx code path");
> > >           PMD_INIT_LOG(DEBUG,
> > > @@ -2301,6 +2381,7 @@ ixgbe_set_tx_function(struct rte_eth_dev *dev,
> > struct ixgbe_tx_queue *txq)
> > >                           (unsigned long)txq->tx_rs_thresh,
> > >                           (unsigned long)RTE_PMD_IXGBE_TX_MAX_BURST);
> > >           dev->tx_pkt_burst = ixgbe_xmit_pkts;
> > > +         dev->tx_pkt_prep = ixgbe_prep_pkts;
> > >   }
> > >  }
> > >
> > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.h
> > > b/drivers/net/ixgbe/ixgbe_rxtx.h index 2608b36..7bbd9b8 100644
> > > --- a/drivers/net/ixgbe/ixgbe_rxtx.h
> > > +++ b/drivers/net/ixgbe/ixgbe_rxtx.h
> > > @@ -80,6 +80,8 @@
> > >  #define RTE_IXGBE_WAIT_100_US               100
> > >  #define RTE_IXGBE_VMTXSW_REGISTER_COUNT     2
> > >
> > > +#define IXGBE_TX_MAX_SEG                    40
> > > +
> > >  #define IXGBE_PACKET_TYPE_MASK_82599        0X7F
> > >  #define IXGBE_PACKET_TYPE_MASK_X550         0X10FF
> > >  #define IXGBE_PACKET_TYPE_MASK_TUNNEL       0XFF
> > > --
> > > 1.7.9.5
> 
> Tomasz.

Reply via email to