Sent from my iPhone On Sep 18, 2016, at 7:28 PM, Yuanhan Liu <yuanhan.liu at linux.intel.com<mailto:yuanhan.liu at linux.intel.com>> wrote:
On Sun, Sep 18, 2016 at 04:20:12PM +0000, Wiles, Keith wrote: Regards, Keith On Sep 18, 2016, at 8:25 AM, Yuanhan Liu <yuanhan.liu at linux.intel.com<mailto:yuanhan.liu at linux.intel.com>> wrote: On Fri, Sep 16, 2016 at 11:22:13AM -0500, Keith Wiles wrote: The rte_eth_tap.c PMD creates a device using TUN/TAP interfaces on the local host. The PMD allows for DPDK and the host to communicate using a raw device interface on the host and in the DPDK application. The device created is a Tap device with a L2 packet header. v2 - merge all of the patches into one patch. Fix a typo on naming the tap device. Update the maintainers list Signed-off-by: Keith Wiles <keith.wiles at intel.com<mailto:keith.wiles at intel.com>> Hi, FYI, my robot caught some build errors with this patch applied. All of the below errors are from Linux header files and not the Tap driver. Yes, but you are referencing them, so ... Yes I am referencing them, but still they are not interacting with the tap driver. It would seem like you could delete all of the code in the tap driver and still get these errors. Which you could try if you want, just ifdef the code and see if it still happens. On my ubuntu 16.04 machine I do not get these errors. I need to know how to reproduce the failure to fix it. How are you building DPDK, which config file are you using, OS version, .... Some details would be nice to understand how these errors are being generated and how I can recreate them. My bad. I should have included all of them: my robot is still at a very rough stage: those info should be included automatically in future (badly, I don't even have time to enhance it). However, for this issue, I think it can be triggered on most (if not any) linux platforms: I got the report from ubuntu-16.04, and I have just tried it on my dev box, which is fedora 20: I got the same error. --yliu --- In file included from /yeti/vm/ubuntu-initrd-16.04-x86_64-build/dpdk/drivers/net/tap/rte_eth_tap.c:50: /usr/include/linux/if.h:71:2: error: redefinition of enumerator 'IFF_UP' IFF_UP = 1<<0, /* sysfs */ ^ /usr/include/net/if.h:45:17: note: expanded from macro 'IFF_UP' # define IFF_UP IFF_UP ^
