2016-09-29 15:16, Iremonger, Bernard: > > 2016-09-29 15:16, Bernard Iremonger: > > > +int > > > +rte_eth_dev_set_vf_vlan_stripq(uint8_t port, uint16_t vf, int on); > > > > Why keeping this function in ethdev? > > This function is using an existing API in the eth_dev_ops structure. > > dev->dev_ops->vlan_strip_queue_set > > The vlan_strip_queue_set API is used by the i40e, ixgbe and mlx5 PMD's.
OK but it was not used to control VF from PF. This line: (*dev->dev_ops->vlan_strip_queue_set)(dev, q + vf * queues_per_pool, on); seems Intel specific. Please keep "VF from PF" outside of ethdev for 16.11. > > I think it would be more consistent to have also existing VF functions > > moving > > from ethdev to rte_pmd_ixgbe.h. > > You cannot remove them, but you can create their ixgbe-specific version and > > announce that the ethdev ones are deprecated. > > There are 5 existing VF functions which are only used by ixgbe PMD at present. > It would make sense to create ixgbe-specific versions, however I think this > should be done in a separate patchset. Yes it can be a separate patchset for RC2 of course.