Hi, olivier > -----Original Message----- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Monday, November 28, 2016 9:25 PM > To: Zhao1, Wei <wei.zh...@intel.com> > Cc: dev@dpdk.org > Subject: Re: [PATCH v2] mempool: remove a redundant word "for" in > comment > > Hi Wei, > > On Mon, 28 Nov 2016 09:42:12 +0100 > Olivier Matz <olivier.m...@6wind.com> wrote: > > Hi Wenzhuo, > > First, sorry for the mistake in your name my previous mail. > > Please find below some other comments about the patch (on the form). > > > On Sun, 27 Nov 2016 10:43:47 +0800 > > Wei Zhao <wei.zh...@intel.com> wrote: > > > > > From: zhao wei <wei.zh...@intel.com> > > > > > > There is a redundant repetition word "for" in commnet line of the > > commnet -> comment > > > > file rte_mempool.h after the definition of > RTE_MEMPOOL_OPS_NAMESIZE. > > > The word "for"appear twice in line 359 and 360.One of them is > > Missing space after '"for"' and after '360.' > > > > > redundant, so delete it. > > > > > > Fixes: 449c49b93a6b (" mempool: support handler operations") > > We should have an empty line after the 'Fixes:' tag. The check-git-log.sh can > help you to notice these errors. > > Also, it is important that no spaces are added in the title of the commit. You > can get the exact line with: > git log -1 --abbrev=12 --format='Fixes: %h (\"%s\")' <commitid> > > > > Signed-off-by: zhao wei <wei.zh...@intel.com> > > The name in your .gitconfig should be the same than in you mail: > Wei Zhao <wei.zh...@intel.com> > > > > Acked-by: John McNamara <john.mcnam...@intel.com> > > > > Acked-by: Olivier Matz <olivier.m...@6wind.com> > > > > Please, could you also check the same comments in the other patch? > > Last thing: when doing another version of the patch, you should add a > changelog that describes what was modified. They take place after the 3 > dashes. > > Thank you for contributing. > > Regards, > Olivier
Thank you for your nicely guide to me, I have found that I miss using check patch tool last time.
