On 12/7/2016 3:32 AM, Wenzhuo Lu wrote: > Add testpmd CLI to set VF multicast promiscuous mode on i40e. > > Signed-off-by: Wenzhuo Lu <wenzhuo...@intel.com> > --- > app/test-pmd/cmdline.c | 86 > +++++++++++++++++++++++++++++ > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 +++ > 2 files changed, 94 insertions(+) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index d39712e..7e7a016 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -407,6 +407,9 @@ static void cmd_help_long_parsed(void *parsed_result, > #ifdef RTE_LIBRTE_I40E_PMD > "set vf unicast-promisc (port_id) (vf_id) (on|off)\n" > " Set unicast promiscuous mode for a VF from the > PF.\n\n" > + > + "set vf multicast-promisc (port_id) (vf_id) (on|off)\n" > + " Set multicast promiscuous mode for a VF from the > PF.\n\n"
Why not "allmulti" instead of multicast-promisc? Also same comments as previous patch for help_str and documentation. <...>