Hi Qiming, On 12/6/2016 7:16 AM, Qiming Yang wrote: > This patch adds a new API 'rte_eth_dev_fwver_get' for fetching firmware > version by a given device. > > Signed-off-by: Qiming Yang <qiming.y...@intel.com>
<...> > @@ -1444,6 +1448,7 @@ struct eth_dev_ops { > /**< Get names of extended statistics. */ > eth_queue_stats_mapping_set_t queue_stats_mapping_set; > /**< Configure per queue stat counter mapping. */ > + eth_fw_version_get_t fw_version_get; /**< Get firmware version. */ Hi Qiming, Not sure if I am missing something but this change is for following [1] deprecation notice, right? If so, notice suggest updating rte_eth_dev_info_get() to include fw_version, but this patch adds a new eth_dev_ops. Is it agreed to add a new eth_dev_ops for this? [1] * In 17.02 ABI change is planned: the ``rte_eth_dev_info`` structure will be extended with a new member ``fw_version`` in order to store the NIC firmware version. > eth_dev_infos_get_t dev_infos_get; /**< Get device info. */ > eth_dev_supported_ptypes_get_t dev_supported_ptypes_get; > /**< Get packet types supported and identified by device*/ <...>