Re: [dpdk-dev] [PATCH] acl: remove invalid test

[Ananyev, Konstantin]

Hi Michal,

> -----Original Message-----
> From: Michał Mirosław [mailto:mirq-li...@rere.qmqm.pl]
> Sent: Wednesday, December 14, 2016 5:24 PM
> To: dev@dpdk.org
> Cc: Ananyev, Konstantin <konstantin.anan...@intel.com>
> Subject: [PATCH] acl: remove invalid test
> 
> rte_acl_add_rules() has no way of checking rule size.
> 
> This was hidden because the test effectively checked that
> adding a rule with userdata == 0 failed.

I suppose that changes have to be inside:
[PATCH v2] acl: allow zero verdict.

Konstantin 


> 
> Signed-off-by: Michał Mirosław <michal.miros...@atendesoftware.pl>
> ---
>  app/test/test_acl.c | 20 --------------------
>  1 file changed, 20 deletions(-)
> 
> diff --git a/app/test/test_acl.c b/app/test/test_acl.c
> index 28955f0..be744ec 100644
> --- a/app/test/test_acl.c
> +++ b/app/test/test_acl.c
> @@ -1515,26 +1515,6 @@ test_invalid_parameters(void)
>       /* free ACL context */
>       rte_acl_free(acx);
> 
> -     /* set wrong rule_size so that adding any rules would fail */
> -     param.rule_size = RTE_ACL_IPV4VLAN_RULE_SZ + 4;
> -     acx = rte_acl_create(&param);
> -     if (acx == NULL) {
> -             printf("Line %i: ACL context creation failed!\n", __LINE__);
> -             return -1;
> -     }
> -
> -     /* try adding a rule with size different from context rule_size */
> -     result = rte_acl_ipv4vlan_add_rules(acx, &rule, 1);
> -     if (result == 0) {
> -             printf("Line %i: Adding an invalid sized rule "
> -                             "should have failed!\n", __LINE__);
> -             rte_acl_free(acx);
> -             return -1;
> -     }
> -
> -     /* free ACL context */
> -     rte_acl_free(acx);
> -
> 
>       /**
>        * rte_acl_ipv4vlan_build
> --
> 2.10.2