Hi Jan,

On Tuesday 20 December 2016 04:41 PM, Jan Blunck wrote:
This is a repost of the series I sent in November. I've addressed Shreyansh's
review comments about the PCI device users I've missed.

Jan Blunck (9):
  eal: define container_of macro
  ethdev: Helper to convert to struct rte_pci_device
  drivers: Use ETH_DEV_PCI_DEV() helper
  virtio: Don't fill dev_info->driver_name
  virtio: Add vtpci_intr_handle() helper to get rte_intr_handle
  virtio: Don't depend on struct rte_eth_dev's pci_dev
  ethdev: Move filling of rte_eth_dev_info->pci_dev to dev_infos_get()
  ethdev: Decouple interrupt handling from PCI device
  ethdev: Decouple struct rte_eth_dev from struct rte_pci_device

 app/test/virtual_pmd.c                     |  4 +-
 drivers/net/bnx2x/bnx2x_ethdev.c           | 13 +++---
 drivers/net/bnxt/bnxt_ethdev.c             | 21 ++++++----
 drivers/net/bnxt/bnxt_ring.c               | 11 ++---
 drivers/net/bonding/rte_eth_bond_args.c    | 12 +++++-
 drivers/net/cxgbe/cxgbe_ethdev.c           |  4 +-
 drivers/net/cxgbe/cxgbe_main.c             |  4 +-
 drivers/net/e1000/em_ethdev.c              | 21 ++++++----
 drivers/net/e1000/igb_ethdev.c             | 52 +++++++++++++----------
 drivers/net/e1000/igb_pf.c                 |  3 +-
 drivers/net/ena/ena_ethdev.c               |  4 +-
 drivers/net/enic/enic_ethdev.c             |  3 +-
 drivers/net/fm10k/fm10k_ethdev.c           | 56 +++++++++++++------------
 drivers/net/i40e/i40e_ethdev.c             | 45 ++++++++++----------
 drivers/net/i40e/i40e_ethdev.h             |  4 ++
 drivers/net/i40e/i40e_ethdev_vf.c          | 39 ++++++++---------
 drivers/net/ixgbe/ixgbe_ethdev.c           | 67 ++++++++++++++++++------------
 drivers/net/ixgbe/ixgbe_pf.c               |  2 +-
 drivers/net/mlx4/mlx4.c                    |  2 +
 drivers/net/mlx5/mlx5_ethdev.c             |  2 +
 drivers/net/nfp/nfp_net.c                  | 17 ++++----
 drivers/net/qede/qede_ethdev.c             | 18 ++++----
 drivers/net/szedata2/rte_eth_szedata2.c    | 28 +++++++------
 drivers/net/szedata2/rte_eth_szedata2.h    | 34 +++++++--------
 drivers/net/thunderx/nicvf_ethdev.c        |  7 +++-
 drivers/net/virtio/virtio_ethdev.c         | 38 ++++++++---------
 drivers/net/virtio/virtio_pci.h            |  6 +++
 drivers/net/virtio/virtio_user_ethdev.c    |  1 -
 drivers/net/vmxnet3/vmxnet3_ethdev.c       |  6 ++-
 lib/librte_eal/common/include/rte_common.h | 20 +++++++++
 lib/librte_eal/common/include/rte_pci.h    |  6 +++
 lib/librte_ether/rte_ethdev.c              | 25 ++++++++---
 lib/librte_ether/rte_ethdev.h              |  9 +++-
 33 files changed, 355 insertions(+), 229 deletions(-)


Besides the MLX* and bnx2x compile errors (responses in individual patch email), all other changes look fine to me.

Either you can directly add my series ACK to v4 or, for ML record purpose, I will do that once you post v4 - whichever way you prefer.

-
Shreyansh

Reply via email to