Hi John, On Wed, Dec 21, 2016 at 10:55:39AM +0000, Mcnamara, John wrote: > Hi Adrien, > > You missed out the changes I suggested to the table_rte_flow_migration_fdir > which means that the pdf build is still broken. Also, the changes to > table_rte_flow_migration_l2tunnel also break the PDF bulid. > > You can test as follows: > > make doc-guides-pdf -j
OK, I'm unable to generate pdf documentation on my setup even though I've installed the dependencies, I usually rely on HTML output only, that's why I did not see the remaining issue. > I'd suggest the following tables which retain the information and format > that you are trying to achieve but which should compile: > > .. _table_rte_flow_migration_fdir: > > .. table:: FDIR conversion > > +----------------------------------------+-----------------------+ > | Pattern | Actions | > +===+===================+==========+=====+=======================+ > | 0 | ETH, RAW | ``spec`` | any | QUEUE, DROP, PASSTHRU | > | | +----------+-----+ | > | | | ``last`` | N/A | | > | | +----------+-----+ | > | | | ``mask`` | any | | > +---+-------------------+----------+-----+-----------------------+ > | 1 | IPV4, IPv6 | ``spec`` | any | MARK | > | | +----------+-----+ | > | | | ``last`` | N/A | | > | | +----------+-----+ | > | | | ``mask`` | any | | > +---+-------------------+----------+-----+-----------------------+ > | 2 | TCP, UDP, SCTP | ``spec`` | any | END | > | | +----------+-----+ | > | | | ``last`` | N/A | | > | | +----------+-----+ | > | | | ``mask`` | any | | > +---+-------------------+----------+-----+ | > | 3 | VF, PF (optional) | ``spec`` | any | | > | | +----------+-----+ | > | | | ``last`` | N/A | | > | | +----------+-----+ | > | | | ``mask`` | any | | > +---+-------------------+----------+-----+ | > | 4 | END | | > +---+------------------------------------+-----------------------+ > > > .. _table_rte_flow_migration_l2tunnel: > > .. table:: L2_TUNNEL conversion > > +---------------------------+--------------------+ > | Pattern | Actions | > +===+======+==========+=====+====================+ > | 0 | VOID | ``spec`` | N/A | VXLAN, GENEVE, ... | > | | | | | | > | | | | | | > | | +----------+-----+ | > | | | ``last`` | N/A | | > | | +----------+-----+ | > | | | ``mask`` | N/A | | > | | | | | | > +---+------+----------+-----+--------------------+ > | 1 | END | VF (optional) | > +---+ +--------------------+ > | 2 | | END | > +---+-----------------------+--------------------+ No problem, I'll include those changes along with a remaining bugfix and testpmd support for additional protocol fields (requested by several people). Brace yourself for v5! Thanks for all the reviews. -- Adrien Mazarguil 6WIND
