On Thu, Dec 22, 2016 at 02:14:45PM +0100, Thomas Monjalon wrote: > 2016-12-02 00:10, Ananyev, Konstantin: > > I have absolutely no problem to remove the RTE_ETHDEV_TX_PREPARE and > > associated logic. > > I personally don't use ARM boxes and don't plan to, > > and in theory users can still do conditional compilation at the upper > > layer, if they want to. > > Yes you're right. The application can avoid calling tx_prepare at all.
There are applications inside dpdk repo which will be using tx_prep so in that case, IMHO, let the ifdef inside the DPDK library and disable it by default so that if required we can disable it in one shot on integrated controllers targets where is the system has only one integrated controller and integrated controller does not need tx_prep > No need of an ifdef inside DPDK.
