Yes, in my opinion it is. And I use this name already exist in the share code from ND team.
-----Original Message----- From: Yigit, Ferruh Sent: Tuesday, January 3, 2017 10:49 PM To: Yang, Qiming <qiming.y...@intel.com> Cc: dev@dpdk.org; Horton, Remy <remy.hor...@intel.com>; Thomas Monjalon <thomas.monja...@6wind.com> Subject: Re: [PATCH v3 1/4] ethdev: add firmware information get On 1/3/2017 9:05 AM, Yang, Qiming wrote: > Hi, Ferruh > Please see the question below. In my opinion, etrack_id is just a name used > to define the ID of one NIC. > In kernel version ethtool, it will print this ID in the line of firmware > verison. > I know what is etrack_id mean, but I really don't know why this named > etrack_id. Hi Qiming, I suggested the API based on fields you already used in your patch. So, this API is to get FW version, is etrack_id something that defines (part of) firmware version? Thanks, ferruh > Can you explain this question? > > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Tuesday, January 3, 2017 4:40 PM > To: Yang, Qiming <qiming.y...@intel.com> > Subject: Re: [PATCH v3 1/4] ethdev: add firmware information get > > Please reply below the question and on the mailing list. > You'll have to explain why this name etrack_id. > > 2017-01-03 03:28, Yang, Qiming: >> Hi, Thomas >> etrack_id is not a terminology, it's decided by me. >> Which is store the unique number of the firmware. >> firmware-version: 5.04 0x800024ca >> 800024ca is the etrack_id of this NIC. >> >> -----Original Message----- >> From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] >> Sent: Monday, January 2, 2017 11:39 PM >> To: Yang, Qiming <qiming.y...@intel.com> >> Cc: dev@dpdk.org; Horton, Remy <remy.hor...@intel.com>; Yigit, Ferruh >> <ferruh.yi...@intel.com> >> Subject: Re: [PATCH v3 1/4] ethdev: add firmware information get >> >> 2016-12-27 20:30, Qiming Yang: >>> /** >>> + * Retrieve the firmware version of a device. >>> + * >>> + * @param port_id >>> + * The port identifier of the device. >>> + * @param fw_major >>> + * A array pointer to store the major firmware version of a device. >>> + * @param fw_minor >>> + * A array pointer to store the minor firmware version of a device. >>> + * @param fw_patch >>> + * A array pointer to store the firmware patch number of a device. >>> + * @param etrack_id >>> + * A array pointer to store the nvm version of a device. >>> + */ >>> +void rte_eth_dev_fw_info_get(uint8_t port_id, uint32_t *fw_major, >>> + uint32_t *fw_minor, uint32_t *fw_patch, uint32_t *etrack_id); >> >> I have a reserve about the naming etrack_id. >> Please could you point to a document explaining this ID? >> Is it known outside of Intel? > >
