-----Original Message-----
From: Yigit, Ferruh
Sent: Wednesday, January 4, 2017 10:00 PM
To: Yang, Qiming <qiming.y...@intel.com>; dev@dpdk.org
Cc: Zhang, Helin <helin.zh...@intel.com>; Horton, Remy <remy.hor...@intel.com>
Subject: Re: [PATCH v4 2/5] net/e1000: add firmware version get
On 1/4/2017 12:03 PM, Qiming Yang wrote:
> This patch adds a new function eth_igb_fw_version_get.
>
> Signed-off-by: Qiming Yang <qiming.y...@intel.com>
> ---
<...>
>
> static void
> +eth_igb_fw_version_get(struct rte_eth_dev *dev, u32 *fw_major, u32 *fw_minor,
> + u32 *fw_patch, u32 *etrack_id)
> +{
<...>
> + default:
> + /* if option rom is valid, display its version too*/
> + if (fw.or_valid) {
> + *fw_major = fw.eep_major;
> + *fw_minor = fw.eep_minor;
> + *etrack_id = fw.etrack_id;
> + *fw_patch = fw.or_patch;
> + /* no option rom */
> + } else {
> + if (fw.etrack_id != 0X0000) {
> + *fw_major = fw.eep_major;
> + *fw_minor = fw.eep_minor;
> + *etrack_id = fw.etrack_id;
indentation is wrong here. Also it looks like major, minor assignment is common
and can be moved from if statement.
Qiming: will correct them
> + } else {
> + *fw_major = fw.eep_major;
> + *fw_minor = fw.eep_minor;
> + }
> + }
> + break;
> + }
> +}
<...>
