Hi Jingjing,
> -----Original Message----- > From: Wu, Jingjing > Sent: Friday, January 6, 2017 8:33 AM > To: Lu, Wenzhuo; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH v7 05/27] net/i40e: set Tx loopback from PF > > Is the Tx lookback meaning as VEB mode ore VEPA mode? > If so, how about change the API's name to set_switch_mode? Yes. It means changing the switch mode between VEB and VEPA. As ixgbe is already using this name. Better to keep it now. We can consider changing both of them later. > > Another comment is: you removed all mac vlan filters before changing The > mode, and restore them after changing. How about vlan filters? The Patch for > vlan anti-spoof enables it, correct? Yes, the vlan table is operated when setting vlan anti-spoofing. Better to do the same thing for it here. > > Thanks > JIngjing >
