-----Original Message----- From: Stephen Hemminger [mailto:[email protected]] Sent: Monday, January 9, 2017 7:05 AM To: Yang, Qiming <[email protected]> Cc: [email protected]; Yigit, Ferruh <[email protected]>; Zhang, Helin <[email protected]>; Horton, Remy <[email protected]> Subject: Re: [dpdk-dev] [PATCH v5 1/5] ethdev: add firmware version get
On Sun, 8 Jan 2017 12:11:31 +0800 Qiming Yang <[email protected]> wrote: > void > +rte_eth_dev_fw_version_get(uint8_t port_id, char *fw_version, int > +fw_length) { > + struct rte_eth_dev *dev; > + > + RTE_ETH_VALID_PORTID_OR_RET(port_id); > + dev = &rte_eth_devices[port_id]; > + > + RTE_FUNC_PTR_OR_RET(*dev->dev_ops->fw_version_get); > + (*dev->dev_ops->fw_version_get)(dev, fw_version, fw_length); } Maybe dev argument to fw_version_get should be: const struct rte_eth_dev *dev Qiming: do you means the argument to ops fw_version_get? why should add 'const'? both two are OK, but we usually use struct rte_eth_dev *dev.
