On 02/23/2017 09:45 AM, Yuanhan Liu wrote:
Some macros (say VIRTIO_NET_F_MQ) are needed for enabling multiple queue,
however they are introduced since kernel v3.8, meaning build error happens
if we build DPDK vhost on those platforms.
71dfdbe66a66 ("vhost: fix build with kernel < 3.8") meant to fix it, but
in a wrong way: it completely disables the MQ features for those kernels.
However, the MQ feature doesn't depend on the kernel at all (except the
macros dependency stated above), that we could still enable the MQ feature
even the host kernel has no such support.
The right fix is to define the macro if it's not defined.
Fixes: 71dfdbe66a66 ("vhost: fix build with kernel < 3.8")
Cc: sta...@dpdk.org
Signed-off-by: Yuanhan Liu <yuanhan....@linux.intel.com>
---
lib/librte_vhost/vhost.c | 2 +-
lib/librte_vhost/vhost.h | 11 ++++-------
lib/librte_vhost/vhost_user.c | 2 +-
3 files changed, 6 insertions(+), 9 deletions(-)
Agree this is the right fix:
Reviewed-by: Maxime Coquelin <maxime.coque...@redhat.com>
Thanks!
Maxime
