On 3/9/2017 5:59 AM, Xing, Beilei wrote: > > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Wednesday, March 8, 2017 11:50 PM >> To: Xing, Beilei <[email protected]>; Wu, Jingjing >> <[email protected]> >> Cc: Zhang, Helin <[email protected]>; [email protected]; Iremonger, >> Bernard <[email protected]>; Stroe, Laura >> <[email protected]> >> Subject: Re: [dpdk-dev] [PATCH 1/4] net/i40e: support replace filter type >> >> On 3/3/2017 9:31 AM, Beilei Xing wrote: >>> Add new admin queue function and extended fields in DCR 288: >>> - Add admin queue function for Replace filter >>> command (Opcode: 0x025F) >>> - Add General fields for Add/Remove Cloud filters >>> command >>> >>> This patch will be removed to base driver in future. >>> >>> Signed-off-by: Bernard Iremonger <[email protected]> >>> Signed-off-by: Stroe Laura <[email protected]> >>> Signed-off-by: Jingjing Wu <[email protected]> >>> Signed-off-by: Beilei Xing <[email protected]> >>> --- >>> drivers/net/i40e/i40e_ethdev.h | 106 ++++++++++++++++++++++++++++ >>> drivers/net/i40e/i40e_flow.c | 152 >> +++++++++++++++++++++++++++++++++++++++++ >>> 2 files changed, 258 insertions(+) >>> >>> diff --git a/drivers/net/i40e/i40e_ethdev.h >>> b/drivers/net/i40e/i40e_ethdev.h index f545850..3a49865 100644 >>> --- a/drivers/net/i40e/i40e_ethdev.h >>> +++ b/drivers/net/i40e/i40e_ethdev.h >>> @@ -729,6 +729,100 @@ struct i40e_valid_pattern { >>> parse_filter_t parse_filter; >>> }; >>> >>> +/* Support replace filter */ >>> + >>> +/* i40e_aqc_add_remove_cloud_filters_element_big_data is used when >>> + * I40E_AQC_ADD_REM_CLOUD_CMD_BIG_BUFFER flag is set. refer to >>> + * DCR288 >> >> Please do not refer to DCR, unless you can provide a public link for it. > OK, got it. > >> >>> + */ >>> +struct i40e_aqc_add_remove_cloud_filters_element_big_data { >>> + struct i40e_aqc_add_remove_cloud_filters_element_data element; >> >> What is the difference between >> "i40e_aqc_add_remove_cloud_filters_element_big_data" and >> "i40e_aqc_add_remove_cloud_filters_element_data", why need big_data >> one? > > As ' Add/Remove Cloud filters -command buffer ' is changed in the DCR288, > 'general fields' exists only when big_buffer is set.
What does it mean having "big_buffer" set? What changes functionally being big_buffer set or not? > But we don't want to change the " > i40e_aqc_add_remove_cloud_filters_element_data " as it will cause ABI/API > change in kernel driver. > <...>
