On Mon, Mar 13, 2017 at 6:51 PM, Thomas Monjalon <[email protected]> wrote: > 2017-03-06 11:56, Jan Blunck: >> This allows the virtual bus to be rescanned and probed by tracking the >> creation of rte_vdev_device. >> >> Signed-off-by: Jan Blunck <[email protected]> >> Tested-by: Ferruh Yigit <[email protected]> >> Acked-by: Shreyansh Jain <[email protected]> > > There are a lot of strcmp in this patch.
Are you sure that you are referring to this patch? There is a single strcmp added here in the find_vdev() helper. > Maybe it should be abstracted in a "match" function. > It would allow bringing new vdev rules in future. Technically that is possible. If I remember correctly we agreed that matching based on the alias is scheduled for removal in a future release. Therefore I believe it is better to keep this in the virtual bus layer implementation instead of moving it down to the PMDs by introducing a driver specific "match" function.
