-----Original Message----- > Date: Fri, 14 Apr 2017 17:04:58 +0100 > From: Harry van Haaren <harry.van.haa...@intel.com> > To: dev@dpdk.org > CC: jerin.ja...@caviumnetworks.com, Harry van Haaren > <harry.van.haa...@intel.com> > Subject: [PATCH] eventdev: fix dequeue timeout bitmask brackets > X-Mailer: git-send-email 2.7.4 > > Fix brackets around the & operator to first mask a single bit > and then perform the not operator. Previously the result was > not as expected, due to the ! operator being performed first. > > As noted on list[1] Clang 4.0 warns about a possible bug for > this type of line: > if (!variable & FLAG) { > > Fixes: 4f0804bbdfb9 ("eventdev: implement the northbound APIs") > > Signed-off-by: Harry van Haaren <harry.van.haa...@intel.com>
Acked-by: Jerin Jacob <jerin.ja...@caviumnetworks.com> > > [1] http://dpdk.org/ml/archives/dev/2017-April/064089.html > --- > lib/librte_eventdev/rte_eventdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_eventdev/rte_eventdev.c > b/lib/librte_eventdev/rte_eventdev.c > index 8042988..a64071e 100644 > --- a/lib/librte_eventdev/rte_eventdev.c > +++ b/lib/librte_eventdev/rte_eventdev.c > @@ -368,7 +368,8 @@ rte_event_dev_configure(uint8_t dev_id, > (*dev->dev_ops->dev_infos_get)(dev, &info); > > /* Check dequeue_timeout_ns value is in limit */ > - if (!dev_conf->event_dev_cfg & RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT) { > + if (!(dev_conf->event_dev_cfg & > + RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT)) { > if (dev_conf->dequeue_timeout_ns < info.min_dequeue_timeout_ns > || dev_conf->dequeue_timeout_ns > > info.max_dequeue_timeout_ns) { > -- > 2.7.4 >