On Wed, Apr 26, 2017 at 05:44:05AM +0000, Tan, Jianfeng wrote:
>
>
> > -----Original Message-----
> > From: Yuanhan Liu [mailto:yuanhan....@linux.intel.com]
> > Sent: Wednesday, April 26, 2017 1:33 PM
> > To: Tan, Jianfeng
> > Cc: dev@dpdk.org; maxime.coque...@redhat.com; tho...@monjalon.net
> > Subject: Re: [PATCH 2/3] net/virtio: clean up LSC setting
> >
> > On Wed, Apr 26, 2017 at 04:52:50AM +0000, Jianfeng Tan wrote:
> > > Clean up LSC setting:
> >
> > Firstly, this patch does two things. There should be two patches.
>
> I just merged them into one to adapt to the name of "clean up" :-)
I then could merge all bug fix patches into one and name it "fix buges"?
No, please don't do that. It hurts review.
> >
> > > - LSC flag is set in several places, but only the last one takes
> > > effect; so we just keep the last one.
> > > - As we already change to use capability list to detect MSI-X, remove
> > > the redundant MSI-X detection in legacy devices.
> >
> > However, there is no capability list for legacy device.
>
> When I try legacy device on QEMU (disable-modern=true), I did detect MSI-X
> capability. So does virtio spec mean legacy devices do not have
> vendor-specific capability list?
Oh, right. I mixed that up.
--yliu
