21/04/2017 17:06, Roman Korynkevych:
> Coverity issue: 143252
> Fixes: 2deb6b5246d7706448d070335b329d1acb754cee ("app/procinfo: add collectd
> format and host id")
> Cc: [email protected]
>
> Signed-off-by: Roman Korynkevych <[email protected]>
> ---
> app/proc_info/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/proc_info/main.c b/app/proc_info/main.c
> index 16b27b2..97d0352 100644
> --- a/app/proc_info/main.c
> +++ b/app/proc_info/main.c
> @@ -189,7 +189,7 @@ proc_info_preparse_args(int argc, char **argv)
> proc_info_usage(prgname);
> return -1;
> }
> - strncpy(host_id, argv[i+1], sizeof(host_id));
> + strncpy(host_id, argv[i+1], sizeof(host_id)-1);
The full array size should be given to strncpy.
However, the call to gethostname below seems wrong as
it does not use the full size.
Maryam, Reshma,
Please review the procinfo patches.
