> -----Original Message----- > From: dev [mailto:[email protected]] On Behalf Of Wu, Jingjing > Sent: Monday, May 8, 2017 9:02 AM > To: Thomas Monjalon <[email protected]>; Dai, Wei <[email protected]> > Cc: [email protected]; Lu, Wenzhuo <[email protected]>; > [email protected]; [email protected]; > [email protected]; [email protected]; Zhang, Helin > <[email protected]>; Ananyev, Konstantin > <[email protected]>; Chen, Jing D <[email protected]>; > [email protected]; [email protected]; Richardson, Bruce > <[email protected]>; [email protected]; > [email protected]; [email protected]; > [email protected]; [email protected] > Subject: Re: [dpdk-dev] [PATCH v7 3/3] app/testpmd: add a command to add > many MAC addrs > > > > > -----Original Message----- > > From: Thomas Monjalon [mailto:[email protected]] > > Sent: Friday, May 5, 2017 10:24 PM > > To: Dai, Wei <[email protected]> > > Cc: [email protected]; Lu, Wenzhuo <[email protected]>; > > [email protected]; [email protected]; > > [email protected]; [email protected]; Zhang, Helin > > <[email protected]>; Ananyev, Konstantin > > <[email protected]>; Wu, Jingjing <[email protected]>; > > Chen, Jing D <[email protected]>; [email protected]; > > [email protected]; Richardson, Bruce > > <[email protected]>; [email protected]; > > [email protected]; [email protected]; > > [email protected]; [email protected] > > Subject: Re: [dpdk-dev] [PATCH v7 3/3] app/testpmd: add a command to > > add many MAC addrs > > > > 05/05/2017 02:40, Wei Dai: > > > This patch is added to introduce a testpmd command which is used to > > > add more than one MAC addresses one time. > > > This command can simplify the test for the change where the type of > > > return value of adding MAC address. > > > Normally a MAC address may fails to be added only after many MAC > > > addresses have been added. > > > Without this command, a tester may only trigger failed MAC address > > > by running many times of testpmd command 'mac_addr add' . > > > > > > Signed-off-by: Wei Dai <[email protected]> > > > --- > > > app/test-pmd/cmdline.c | 55 > > > ++++++++++++++++++++++++++++++++++++++++++++++++++ > > > 1 file changed, 55 insertions(+) > > > > This patch has not been reviewed. > > It is not a fix and I am not sure it is needed. > > The same doubt, what is this relationship with your fix in Patch 1/3? > If it is only for testing for special case, and it can be done through calling 'mac_addr add' by multi times. I'd like to Nack it.
Thanks Jingjing
