Hi Ferruh: > -----Original Message----- > From: Yigit, Ferruh > Sent: Tuesday, May 23, 2017 9:21 PM > To: Zhang, Qi Z <[email protected]>; Lu, Wenzhuo > <[email protected]>; Zhang, Helin <[email protected]> > Cc: [email protected] > Subject: Re: [dpdk-dev] [PATCH 3/3] net/ixgbe: enable flex bytes for generic > flow > API > > On 5/23/2017 4:59 AM, Qi Zhang wrote: > > Add fdir flex byte support for rte_flow APIs. > > > > Signed-off-by: Qi Zhang <[email protected]> > > Hi Qi, > > There are a few checkpatch errors for this patch also please find a few minor > syntax issues below.
Yes I also got notification from [email protected]. Will fix them also with below captures in V2 Thanks Qi > > <...> > > > +int > > +ixgbe_fdir_set_flexbytes_offset(struct rte_eth_dev *dev, > > + uint16_t offset) > > +{ > > + uint32_t fdirctrl; > > + int i; > > + struct ixgbe_hw *hw = > > +IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); > > We don't have "reverse christmas tree declarations", right J > > <...> > > > + > > + /*Not supported last point for range*/ > > Spaces around comment. > > <...> > > > + /** > > + * mask should not be null > > + */ > > Can have single line comment.
