-----Original Message-----
> Date: Fri, 23 Jun 2017 12:36:47 +0000
> From: "Van Haaren, Harry" <[email protected]>
> To: Jerin Jacob <[email protected]>, "[email protected]"
>  <[email protected]>
> CC: "Richardson, Bruce" <[email protected]>,
>  "[email protected]" <[email protected]>, "Eads, Gage"
>  <[email protected]>, "[email protected]" <[email protected]>,
>  "Vangati, Narender" <[email protected]>, "Rao, Nikhil"
>  <[email protected]>, "[email protected]"
>  <[email protected]>
> Subject: RE: [dpdk-dev] [PATCH 14/33] app/testeventdev: order: add eventdev
>  port setup
> 
> > From: Jerin Jacob [mailto:[email protected]]
> > Sent: Sunday, May 28, 2017 8:59 PM
> > To: [email protected]
> > Cc: Richardson, Bruce <[email protected]>; Van Haaren, Harry
> > <[email protected]>; [email protected]; Eads, Gage 
> > <[email protected]>;
> > [email protected]; Vangati, Narender <[email protected]>; Rao, 
> > Nikhil
> > <[email protected]>; [email protected]; Jerin Jacob
> > <[email protected]>
> > Subject: [dpdk-dev] [PATCH 14/33] app/testeventdev: order: add eventdev 
> > port setup
> > 
> > Setup one port per worker and link to all queues and setup
> > one producer port to inject the events.
> > 
> > Signed-off-by: Jerin Jacob <[email protected]>
> 
> One suggestion below to increase the enqueue depth, or was there a reason set 
> it to 8?

No specific reason. I think, In some example, SW driver was configuring to 8.
So I choose to select 8. I will change to 32 as you suggested.

> 
> Acked-by: Harry van Haaren <[email protected]>
> 
> 
> <snip some code>
> 
> > +   /* setup one port per worker, linking to all queues */
> > +   for (port = 0; port < nb_workers; port++) {
> > +           struct worker_data *w = &t->worker[port];
> > +
> > +           w->dev_id = opt->dev_id;
> > +           w->port_id = port;
> > +           w->t = t;
> > +
> > +           ret = rte_event_port_setup(opt->dev_id, port, &wkr_p_conf);
> > +           if (ret) {
> > +                   evt_err("failed to setup port %d", port);
> > +                   return ret;
> > +           }
> > +
> > +           ret = rte_event_port_link(opt->dev_id, port, NULL, NULL, 0);
> > +           if (ret != nb_queues) {
> > +                   evt_err("failed to link all queues to port %d", port);
> > +                   return -EINVAL;
> > +           }
> > +   }
> > +   /* port for producer, no links */
> > +   const struct rte_event_port_conf prod_conf = {
> > +                   .dequeue_depth = 8,
> > +                   .enqueue_depth = 8,
> 
> .enqueue_depth = 32 or so?
> 

Reply via email to